Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@hatpick
Copy link
Contributor

@hatpick hatpick commented Jun 24, 2020

Description

• Update prettier config and editor config for standard OSS formatted code
• Ensure these get matched with any PR checks
• Turn on format on save

Task Item

closes #3485

Screenshots

N/A

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.818% when pulling d727cd2 on hatpick:master into fd5d15a on microsoft:master.

@a-b-r-o-w-n a-b-r-o-w-n changed the title fix: #3485 Code hygiene: Hide ignored folders in vscode, update prettier config chore: Hide ignored folders in vscode, update prettier config Jun 24, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit 7a79033 into microsoft:master Jun 24, 2020
beyackle added a commit that referenced this pull request Jun 29, 2020
* link the application keys with bot service in provision script (#3425)

* fix: #3309 Allow configuring app settings without opening a bot project (#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <[email protected]>

* fix: fix relative path of runtime folder in eject customized (#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <[email protected]>

* fix: typo (#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Dong Lei <[email protected]>

* fix: #2692 Tabbing / clicking / returning out of a number field round your input (#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* fix: revert plugins out of workspace (#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>

* chore: Hide ignored folders in vscode, update prettier config (#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: #3485

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (#3498)

* refactor: add rule and remove dangling underscores (#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <[email protected]>

* chore: added config to debug Electron main process. (#3501)

Co-authored-by: Andy Brown <[email protected]>

* Merge pull request #3502 from hatpick/master

fix: #3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <[email protected]>

* feat: support validate lg custom functions (#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <[email protected]>

* refactor: change term primary key to authoring key (#3516)

Co-authored-by: Andy Brown <[email protected]>

Co-authored-by: Qi Kang <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: zeye <[email protected]>
Co-authored-by: VanyLaw <[email protected]>
Co-authored-by: Yan Liu <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: LouisEugeneMSFT <[email protected]>
Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: Tony Anziano <[email protected]>
Co-authored-by: Zhixiang Zhan <[email protected]>
Co-authored-by: liweitian <[email protected]>
@cwhitten cwhitten mentioned this pull request Jul 8, 2020
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* link the application keys with bot service in provision script (microsoft#3425)

* fix: microsoft#3309 Allow configuring app settings without opening a bot project (microsoft#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (microsoft#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <[email protected]>

* fix: fix relative path of runtime folder in eject customized (microsoft#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <[email protected]>

* fix: typo (microsoft#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (microsoft#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Dong Lei <[email protected]>

* fix: microsoft#2692 Tabbing / clicking / returning out of a number field round your input (microsoft#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* fix: revert plugins out of workspace (microsoft#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>

* chore: Hide ignored folders in vscode, update prettier config (microsoft#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: microsoft#3485

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (microsoft#3498)

* refactor: add rule and remove dangling underscores (microsoft#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <[email protected]>

* chore: added config to debug Electron main process. (microsoft#3501)

Co-authored-by: Andy Brown <[email protected]>

* Merge pull request microsoft#3502 from hatpick/master

fix: microsoft#3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (microsoft#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <[email protected]>

* feat: support validate lg custom functions (microsoft#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (microsoft#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <[email protected]>

* refactor: change term primary key to authoring key (microsoft#3516)

Co-authored-by: Andy Brown <[email protected]>

Co-authored-by: Qi Kang <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: zeye <[email protected]>
Co-authored-by: VanyLaw <[email protected]>
Co-authored-by: Yan Liu <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: LouisEugeneMSFT <[email protected]>
Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: Tony Anziano <[email protected]>
Co-authored-by: Zhixiang Zhan <[email protected]>
Co-authored-by: liweitian <[email protected]>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* link the application keys with bot service in provision script (#3425)

* fix: #3309 Allow configuring app settings without opening a bot project (#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <[email protected]>

* fix: fix relative path of runtime folder in eject customized (#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <[email protected]>

* fix: typo (#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Dong Lei <[email protected]>

* fix: #2692 Tabbing / clicking / returning out of a number field round your input (#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* fix: revert plugins out of workspace (#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>

* chore: Hide ignored folders in vscode, update prettier config (#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: #3485

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (#3498)

* refactor: add rule and remove dangling underscores (#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <[email protected]>

* chore: added config to debug Electron main process. (#3501)

Co-authored-by: Andy Brown <[email protected]>

* Merge pull request #3502 from hatpick/master

fix: #3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <[email protected]>

* feat: support validate lg custom functions (#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <[email protected]>

* refactor: change term primary key to authoring key (#3516)

Co-authored-by: Andy Brown <[email protected]>

Co-authored-by: Qi Kang <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: zeye <[email protected]>
Co-authored-by: VanyLaw <[email protected]>
Co-authored-by: Yan Liu <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: LouisEugeneMSFT <[email protected]>
Co-authored-by: Louis Eugene <[email protected]>
Co-authored-by: leilzh <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: Tony Anziano <[email protected]>
Co-authored-by: Zhixiang Zhan <[email protected]>
Co-authored-by: liweitian <[email protected]>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…oft#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: microsoft#3485

Co-authored-by: Soroush <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code hygiene: Hide ignored folders in vscode, update prettier config

5 participants